feat: Clusters, container resource management and server info views#48
Merged
feat: Clusters, container resource management and server info views#48
Conversation
Display server hostname, public IPs, network health status, DNS resolver checks, and network interfaces under System nav. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Place nav-count badges after the label text and use margin-left auto so counts align to the right edge for better readability. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Renamed the dashboard section to avoid confusion with deployment quick actions. Added Server Info shortcut linking to the new view. Signed-off-by: nfebe <fenn25.fn@gmail.com>
View and update CPU, memory, swap, and CPU shares for containers. Accessible from both the containers list and deployment detail service actions. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Cluster page showing status, peer list, invite generation, join flow, and peer removal. Added cluster permissions to type system and navigation under System group. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Replace static "Local Environment" with dynamic dropdown showing current server name fetched from cluster API, listing cluster peers and linking to cluster management. Also show node count badge on Cluster nav item. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThis PR introduces cluster management, container resource tuning, and server information views. It effectively expands the infrastructure management capabilities of the UI. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| }; | ||
|
|
||
| const saveResources = async () => { | ||
| if (!props.containerId || !hasChanges.value) return; |
There was a problem hiding this comment.
When calling hasChanges.value, the logic depends on resources.value. However, the API call below does not verify if resources.value is still defined before accessing its properties. While unlikely given the v-else-if in the template, a defensive check or local constant is safer.
Suggested change
| if (!props.containerId || !hasChanges.value) return; | |
| const current = resources.value; | |
| if (!props.containerId || !hasChanges.value || !current) return; |
| } | ||
| }; | ||
|
|
||
| const copyToken = async () => { |
There was a problem hiding this comment.
The navigator.clipboard.writeText API is only available in secure contexts (HTTPS or localhost). It's good practice to provide a fallback or check for existence to prevent runtime errors in non-standard environments.
Suggested change
| const copyToken = async () => { | |
| const copyToken = async () => { | |
| if (!navigator.clipboard) { | |
| notifications.error("Error", "Clipboard API not available"); | |
| return; | |
| } | |
| await navigator.clipboard.writeText(inviteToken.value); |
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Deploying flatrun-ui with
|
| Latest commit: |
0fc08d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04fdef1d.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-ui-clusters-server-info.flatrun-ui.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new views to manage container resources allocation, cluster management (each agent server is a peer), and implementation of basic server info