Conversation
added 2 commits
March 26, 2026 03:49
…s after
getHeaderMenuItems() was using a flat sortBy('priority') across all items,
including shortcuts. Shortcuts are assigned priority = parentPriority + 1,
so a Fleet-Ops shortcut (priority 2) would sort between Fleet-Ops (priority 1)
and Pallet (priority 2), interleaving shortcuts with real extensions.
The smart-nav-menu component builds the default pinned bar by slicing the
first maxVisible (5) items from this list, so the bar ended up showing
Fleet-Ops + its 4 shortcuts instead of the first 5 extensions.
Fix: filter items into two groups before sorting — extensions sort by priority
as before, shortcuts are appended at the end in registration order. This
guarantees shortcuts never displace real extensions from the default bar,
regardless of what priority values extensions choose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getHeaderMenuItems()was using a flatsortBy('priority')across all items, including shortcuts. Shortcuts are assignedpriority = parentPriority + 1, so a Fleet-Ops shortcut (priority 2) would sort between Fleet-Ops (priority 1) and Pallet (priority 2), interleaving shortcuts with real extensions.The
smart-nav-menucomponent builds the default pinned bar by slicing the firstmaxVisible(5) items from this list, so the bar ended up showing Fleet-Ops + its 4 shortcuts instead of the first 5 extensions.Fix
Filter items into two groups before sorting — extensions sort by
priorityas before, shortcuts are appended at the end in registration order:This guarantees shortcuts never displace real extensions from the default bar, regardless of what priority values extensions choose.