feat(): remove deprecated remove_non_manifold_faces key from meshing defaults

[benflexcompute]

…g

---

Note

Low Risk
Small, targeted deprecation cleanup with backwards-compat shims; main risk is behavioral change for users still passing the removed key (now ignored with a warning).

Overview
Removes the deprecated meshing.defaults.remove_non_manifold_faces field from MeshingDefaults, the GAI translation whitelist, and all JSON test fixtures/refs, and drops the now-obsolete mutual-exclusion validation/test that involved this flag.

Adds compatibility handling so older inputs are auto-cleaned: a new _to_25_9_0 updater step (not yet registered) strips the key from serialized params, and a MeshingDefaults pre-validator drops the constructor argument while emitting a validation warning and directing users to remove_hidden_geometry instead.

^{Written by Cursor Bugbot for commit 5d3b979. This will update automatically on new commits. Configure here.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d98fce700b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

[cursor]

Deprecation warning fires unconditionally regardless of value

Medium Severity

The remove_deprecated_arguments validator emits a deprecation warning whenever remove_non_manifold_faces is present in the input, regardless of its value. All old serialized configs include this field with its default value of False. Since _to_25_9_0 is not yet registered in VERSION_MILESTONES, loading any old config triggers the warning from the model validator. The warning message "Set meshing.defaults.remove_hidden_geometry instead" is misleading for users who never enabled the deprecated feature. Per the PR discussion, the reviewer suggested showing the warning only when the value is True, and the response was "GOOD CATCH." The check on value currently only tests key presence, not the truthiness of the value.