Implement MCMC mapping/optimization algorithm#1619
Open
victorli2002 wants to merge 5 commits intoflexflow:masterfrom
Open
Implement MCMC mapping/optimization algorithm#1619victorli2002 wants to merge 5 commits intoflexflow:masterfrom
victorli2002 wants to merge 5 commits intoflexflow:masterfrom
Conversation
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
| @@ -0,0 +1,197 @@ | |||
| #include "compiler/machine_mapping/apply_substitution_and_update_machine_mapping.h" | |||
Collaborator
Author
There was a problem hiding this comment.
somehow break this up and remove some dup with the base apply_substitution
try to add tests
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
| if (allowed_machine_views.empty()) { | ||
| return std::nullopt; | ||
| } | ||
| machine_views.insert({layer, *(allowed_machine_views.begin())}); |
Collaborator
Author
There was a problem hiding this comment.
get_first or something in containers / util or write one
Collaborator
Author
|
in general, try to use transforms / maps / optional.h / stuff in containers instead of the big for loops |
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
lib/compiler/include/compiler/machine_mapping/machine_mapping_mutation_set.h
Show resolved
Hide resolved
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
lib/compiler/include/compiler/machine_mapping/machine_mapping_mutation_set.h
Outdated
Show resolved
Hide resolved
victorli2002
commented
Nov 20, 2025
victorli2002
commented
Nov 20, 2025
…into moving it to the other file, also put the evaluate_substitution_ouput outside of apply_substitution since it has a side effect, thinking of making the non-eval-sub version the default
lockshaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is