Gate preview mesh updates to value-input descendant changes#305
Open
tracygardner wants to merge 2 commits intomainfrom
Open
Gate preview mesh updates to value-input descendant changes#305tracygardner wants to merge 2 commits intomainfrom
tracygardner wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
create_mapMATERIAL) and reduce duplication.Description
isValueInputDescendantOf(containerBlock, changedBlock)inblocks/blocks.jsthat returnstruefor self-updates or when every parent hop fromchangedBlocktocontainerBlockis through aVALUEinput connection.handleFieldOrChildChangewith the new helper while keeping direct owner-field updates intact.handleBlockChangesoupdateOrCreateMeshFromBlockis only called when a resolvablechangedBlockexists andisValueInputDescendantOf(block, changedBlock)istrue, and add the inline comment: "Only configuration inputs (value-input subtree) affect preview mesh; runtime statement blocks do not."load_objectand other load/create blocks that delegate tohandleBlockChangenow automatically benefit from the stricter VALUE-input-descendant gating without per-block duplication.Testing
npx eslint blocks/blocks.js blocks/models.js, which reported existing repository-level lint errors unrelated to the new helper and change (the lint run failed).Codex Task