Align mesh base Y and remove legacy yOffset compensation#308
Merged
tracygardner merged 3 commits intomainfrom Feb 22, 2026
Merged
Align mesh base Y and remove legacy yOffset compensation#308tracygardner merged 3 commits intomainfrom
tracygardner merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
yOffsetcompensation and make mesh placement geometry-consistent by aligning the mesh base to the requested Y once during setup (and again when deferred ground resolution occurs).Description
alignMeshBaseToYhelper inapi/mesh.jsand call it during mesh initialization and after deferred ground-level resolution to align the wrapped mesh base to the requested Y.metadata.yOffsetinapi/mesh.jsso initialization no longer persists runtime Y compensation data.calculateYPositioninui/blocklyutil.jsreturnmesh.position.ydirectly and rename the unused parameter to_blockto avoid unused-variable warnings.ui/gizmos.jsto use the direct calculated mesh Y and stop subtracting the bounding-box extent so block position mirrors the mesh transform.Testing
npx eslint api/mesh.js ui/blocklyutil.js ui/gizmos.js; the run still fails due to multiple pre-existing lint issues unrelated to this change, though this PR removes the local unused-arg forcalculateYPositionby renaming the parameter to_block.Codex Task