Inline placement helpers into transform and remove api/placement.js#311
Merged
tracygardner merged 3 commits intomainfrom Feb 22, 2026
Merged
Inline placement helpers into transform and remove api/placement.js#311tracygardner merged 3 commits intomainfrom
tracygardner merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
api/transform.jsto avoid expanding the public API surface prematurely.Description
api/placement.jsand removed itsflockwiring fromflock.js(import, spread, and initialization call) to avoid unused API surface.resolvePositionInputsandapplyPositionWithCurrentBaseRuleinsideapi/transform.jsand updatedpositionAtto callapplyPositionWithCurrentBaseRuleinstead of inlining the base-alignment logic.api/transform.jsfor incremental migration.Testing
npm run lint, which failed due to existing unrelated lint issues inflock.js(twono-emptyblock statements and an undefinedhideLoadingScreen), so lint did not pass; the failures are pre-existing and outside the change scope.Inline placement scaffold in transform and remove extra placement moduleand updated the PR description to reflect the review-driven removal of the extra module.Codex Task