-
Notifications
You must be signed in to change notification settings - Fork 19
FDN-4261: switch to Shenandoah GC #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Argo diff output for dependency-www:===== /Service production/dependency-www ======
11c11
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60
===== apps/Deployment production/dependency-www-live ======
16c16
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60
552,553c552,554
< value: -Xms2100m -Xmx2100m -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/dumps/oom.bin
< -XX:+UseG1GC -XX:+UseStringDeduplication -XX:FlightRecorderOptions=stackdepth=256
---
> value: -Xms2100m -Xmx2100m -XX:+UseShenandoahGC -XX:+HeapDumpOnOutOfMemoryError
> -XX:HeapDumpPath=/dumps/oom.bin -XX:+UseStringDeduplication -XX:FlightRecorderOptions=stackdepth=256
> -Xlog:gc*:stdout:time,uptime,level,tags
===== datadoghq.com/DatadogMonitor datadog/dependency-www-errorrate ======
145d144
< - generated:kubernetes
===== networking.istio.io/Gateway production/dependency-www-flow-io ======
17c17
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60
===== networking.istio.io/VirtualService production/dependency-www-live ======
12c12
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60 |
Argo diff output for dependency-api:===== /Service production/dependency ======
11c11
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60
===== apps/Deployment production/dependency-api-live ======
16c16
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60
552,553c552,554
< value: -Xms2100m -Xmx2100m -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/dumps/oom.bin
< -XX:+UseG1GC -XX:+UseStringDeduplication -XX:FlightRecorderOptions=stackdepth=256
---
> value: -Xms2100m -Xmx2100m -XX:+UseShenandoahGC -XX:+HeapDumpOnOutOfMemoryError
> -XX:HeapDumpPath=/dumps/oom.bin -XX:+UseStringDeduplication -XX:FlightRecorderOptions=stackdepth=256
> -Xlog:gc*:stdout:time,uptime,level,tags
===== datadoghq.com/DatadogMonitor datadog/dependency-api-errorrate ======
145d144
< - generated:kubernetes
===== networking.istio.io/Gateway production/dependency-flow-io ======
17c17
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60
===== networking.istio.io/VirtualService production/dependency-api-live ======
12c12
< helm.sh/chart: flow-generic-1.6.59
---
> helm.sh/chart: flow-generic-1.6.60 |
Includes fix to disable the major GC pause DD monitor for ShenandoahGC, since the metric includes concurrent phase times. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughUpdates two deployment configurations with chart version bump from v2.0.7 to v2.0.12 and adds ShenandoahGC garbage collector option to JVM configuration for both dependency-api and dependency-www services. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Comment |
Summary
garbageCollectorknobTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit