Allow overriding MSVC runtime library setting in CMake#340
Open
emuell wants to merge 1 commit intoflucoma:mainfrom
Open
Allow overriding MSVC runtime library setting in CMake#340emuell wants to merge 1 commit intoflucoma:mainfrom
emuell wants to merge 1 commit intoflucoma:mainfrom
Conversation
Update CMAKE_MSVC_RUNTIME_LIBRARY to use CACHE option.
Member
|
@weefuzzy is currently working on the cmake stuff, so maybe this is timely to be added? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on Rust bindings for FluCoMa, based on flucoma-core. See https://github.com/emuell/flucoma-rs
This still is a WIP, but works great so far, with one little caveat: Rust by default uses the Multi-threaded DLL runtime with msvc targets. This can be overridden, but is quite awkward and requires all users of the flucoma-rs crate to override the runtime as well which may cause various other problems.
flucoma-core right now does not allow overriding the CMAKE CMAKE_MSVC_RUNTIME_LIBRARY variables. This PR changes this. The default still is /MT, so this should not break anything else.