Conversation
7b2fa55 to
8cfccd0
Compare
|
Waiting for https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/10088#note_3191662 to conclude before proceeding with a proper review here |
|
@dabrain34 I have opened #323 with a new runner that can be customized to handle errors more easily. |
|
That's sound great, let me give it a try |
|
Do you agree to close this PR, @dabrain34 ? Have you seen the changes in this PR? |
|
why do you want to close this MR as the idea would be to treat |
You're right, sorry for the confusion. These two PRs are complementary, looking more in detail, this one handles the reporting side, #323 handles the runner side. We'll just need to coordinate the exit codes between them... |
rsanchez87
left a comment
There was a problem hiding this comment.
Looks good to me, the full path from exit code 69 through to JUnit/CSV/markdown reports is consistent and well wired up.
|
@dabrain34 , there are merge conflicts with master, looks like Can you rebase? |
|
We should support this in an agnostic way through the NotSupportedExpeception without binding it to the 69 exit code since each decoder implementation might signal this in different ways. As a matter of fact, the GStreamer decoders will not use 69 exit code but instead the runner should raise that exception so it can be handled in a generic way by the test case. |
sounds good to me |
Add a NotSupportedError exception in the decoder layer that individual decoders can raise when they cannot handle a media format. The VVS decoder raises it on exit code 69 (EX_UNAVAILABLE). The framework catches it as a non-error status: - NOT_SUPPORTED and FAIL/ERROR rows in markdown/JSON summaries - JUnit XML reports NOT_SUPPORTED as skipped - Process exits 0 when all vectors are success or not supported
8cfccd0 to
4fdea1a
Compare
|
@rsanchez87 rebased and modified to support NotSupported exception in Vulkan Video Samples decoder class |
In case of 69 exit code from an app, the test should be reported as not supported and be considered as non-error status.