RDI-3295 - Add AC4 decoder configuration sample comparison#349
Merged
rsanchez87 merged 3 commits intomasterfrom Apr 16, 2026
Merged
RDI-3295 - Add AC4 decoder configuration sample comparison#349rsanchez87 merged 3 commits intomasterfrom
rsanchez87 merged 3 commits intomasterfrom
Conversation
rsanchez87
force-pushed
the
RDI-3295
branch
2 times, most recently
from
11777f6 to
eff3e0c
Compare
rsanchez87
changed the title
rsanchez87
changed the title
rsanchez87
force-pushed
the
RDI-3295
branch
3 times, most recently
from
6143619 to
c11ddb9
Compare
Contributor
|
@rsanchez87 @rgonzalezfluendo aren't there another PR that implements additional changes on top of my PR #321 which waits for Andoni's review? |
rgonzalezfluendo
requested changes
Apr 10, 2026
rsanchez87
force-pushed
the
RDI-3295
branch
4 times, most recently
from
c39a121 to
f95c693
Compare
Contributor
Author
#321 is already merged |
Contributor
|
@msabiniok can you review this? |
msabiniok
requested changes
Apr 15, 2026
| def __init__(self) -> None: | ||
| self.codec = Codec.AC4 | ||
| self.decoder_bin = "fluac4dec" | ||
| self.decoder_bin = "fluac4dec presentation-index=0" |
Contributor
There was a problem hiding this comment.
i think presentation-index=0 should be specify in vector parameters if other then 0. 0 is a defualt so no need to check it here.
| """Generate pipeline, mapping decoder_speaker_config to fluac4dec's decoder-speaker-config property.""" | ||
| output = f"location={output_filepath}" if output_filepath else "" | ||
| decoder_bin = self.decoder_bin | ||
| if optional_params and "decoder_speaker_config" in optional_params: |
Contributor
There was a problem hiding this comment.
in this loop we shold take into account all optional parameters that may affect decoder output - drc_mode, de-gain, presentation-index, renderer-bypass and speaker confifis.
rsanchez87
requested review from
rgonzalezfluendo
and removed request for
rgonzalezfluendo
- `TestVector`: new optional `decoder_config` dict field, serialised to/from JSON only when present (same pattern as `profile`). - `Decoder.decode()`: extended abstract signature with optional `decoder_config` parameter (backward-compatible default: None). - All `Decoder` subclasses updated to accept and forward the parameter. - `GStreamer`: `FluendoFluAC4DecGst10Decoder` overrides `gen_pipeline` to consume `decoder_speaker_config` from `decoder_config`. - `utils`: `compare_byte_wise_files` extended with WAV-aware comparison that filters silent reference channels and compensates for stream lag, used by the AC4 byte-wise conformance check. - `AC4_ELEMENTARY_STREAMS`: test vectors updated with `decoder_config` carrying the required `decoder_speaker_config` per stream. - New sample comparison method for AC4 - Remove IMS test vectors from AC4 test suite - Decouple reference comparison tests from byte-wise dispatcher (utils)
- Remove unnecessary `self.parser if self.parser else "parsebin"` guards in GStreamer.gen_pipeline and GStreamerVideo.gen_pipeline; parser is always a non-empty string
rgonzalezfluendo
approved these changes
Apr 15, 2026
msabiniok
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To bring changes from this PR (#321)
Map
fluac4decchannel order&config to the reference decoder one.`$ GST_PLUGIN_PATH=/home/rsanchez/Downloads python3 ./fluster.py run -ts AC4_ELEMENTARY_STREAMS -d DolbyPADSReferenceDecoder Fluendo-AC4-SW -s
Running test suite AC4_ELEMENTARY_STREAMS with decoder DolbyPADSReferenceDecoder
Using 16 parallel job(s)
[TEST SUITE ] (DECODER ) TEST VECTOR ... RESULT
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Audio_ID_2ch_64kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Audio_ID_2ch_64kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Audio_ID_514ch_192kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Audio_ID_6ch_128kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Audio_ID_6ch_128kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Audio_ID_514ch_192kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Holi_fr_6ch_128kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Holi_fr_6ch_128kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Holi_en_6ch_128kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (DolbyPADSReferenceDecoder) Holi_en_6ch_128kbps_2997fps_ac4.ac4 ... Success
Ran 10/10 tests successfully in 5.791 secs
Running test suite AC4_ELEMENTARY_STREAMS with decoder Fluendo-AC4-SW
Using 16 parallel job(s)
[TEST SUITE ] (DECODER ) TEST VECTOR ... RESULT
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Audio_ID_2ch_64kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Audio_ID_6ch_128kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Audio_ID_2ch_64kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Audio_ID_6ch_128kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Audio_ID_514ch_192kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Audio_ID_514ch_192kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Holi_en_6ch_128kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Holi_fr_6ch_128kbps_25fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Holi_fr_6ch_128kbps_2997fps_ac4.ac4 ... Success
[AC4_ELEMENTARY_STREAMS] (Fluendo-AC4-SW) Holi_en_6ch_128kbps_2997fps_ac4.ac4 ... Success
Ran 10/10 tests successfully in 6.252 secs
Generating summary for test suite AC4_ELEMENTARY_STREAMS and decoders DolbyPADSReferenceDecoder, Fluendo-AC4-SW:
System Information
OS: Linux 6.17.0-20-generic
CPU: AMD Ryzen 7 7745HX with Radeon Graphics
GPU: 00.0 VGA compatible controller: NVIDIA Corporation AD107M, 00.0 VGA compatible controller: Advanced Micro Devices, Inc. [PRIMARY]
RAM: 30.5 GB
Backends:
GLOBAL SUMMARY