CI: windows: add workaround for unexpected exception#4747
Merged
kenhys merged 1 commit intofluent:masterfrom Dec 26, 2024
Merged
CI: windows: add workaround for unexpected exception#4747kenhys merged 1 commit intofluent:masterfrom
kenhys merged 1 commit intofluent:masterfrom
Conversation
Contributor
|
Thanks! |
Contributor
Author
|
rebase after #4746 |
daipom
reviewed
Dec 26, 2024
kenhys
force-pushed
the
hold-logger-162
branch
from
059d79f to
f843382
Compare
Contributor
|
@kenhys Can we merge this now? Should we rebase this? |
Since logger 1.6.3 or later, there is a bug that it cause unexpected exception (no implicit conversion of Integer into String (TypeError)) on windows. So hold on 1.6.2 for a while. See ruby/logger#107 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
hold-logger-162
branch
from
f843382 to
eb709f1
Compare
Contributor
Author
|
rebased now. |
kenhys
added a commit
that referenced
this pull request
Jan 29, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Since logger 1.6.3 or later, there is a bug that it cause unexpected exception (no implicit conversion of Integer into String (TypeError)) on windows. So hold on 1.6.2 for a while. See ruby/logger#107 **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
daipom
pushed a commit
that referenced
this pull request
Jan 29, 2025
…) (#4800) **Which issue(s) this PR fixes**: Backport #4747 **What this PR does / why we need it**: Since logger 1.6.3 or later, there is a bug that it cause unexpected exception (no implicit conversion of Integer into String (TypeError)) on windows. So hold on 1.6.2 for a while. See ruby/logger#107 **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Contributor
|
Does this problem affect Fluentd's actual behavior? Or is this a CI-only issue? |
Contributor
|
This affects CI only. |
daipom
changed the title
Watson1978
added a commit
to Watson1978/fluentd
that referenced
this pull request
Feb 14, 2025
This reverts commit b193dc4. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
daipom
pushed a commit
that referenced
this pull request
Feb 17, 2025
) **Which issue(s) this PR fixes**: Fixes #4742 **What this PR does / why we need it**: This reverts commit b193dc4. Because ruby/logger#107 was fixed. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
…" (fluent#4833) **Which issue(s) this PR fixes**: Fixes fluent#4742 **What this PR does / why we need it**: This reverts commit b193dc4. Because ruby/logger#107 was fixed. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
…" (fluent#4833) **Which issue(s) this PR fixes**: Fixes fluent#4742 **What this PR does / why we need it**: This reverts commit b193dc4. Because ruby/logger#107 was fixed. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
…" (fluent#4833) **Which issue(s) this PR fixes**: Fixes fluent#4742 **What this PR does / why we need it**: This reverts commit b193dc4. Because ruby/logger#107 was fixed. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
…" (fluent#4833) **Which issue(s) this PR fixes**: Fixes fluent#4742 **What this PR does / why we need it**: This reverts commit b193dc4. Because ruby/logger#107 was fixed. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
…" (fluent#4833) **Which issue(s) this PR fixes**: Fixes fluent#4742 **What this PR does / why we need it**: This reverts commit b193dc4. Because ruby/logger#107 was fixed. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
daipom
pushed a commit
that referenced
this pull request
Apr 24, 2025
…tion (#4747)" (#4833) (#4923) **Which issue(s) this PR fixes**: Backport #4833 Fixes #4742 **What this PR does / why we need it**: This reverts commit b193dc4. Because ruby/logger#107 was fixed. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Shizuo Fujita <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Since logger 1.6.3 or later, there is a bug that it cause unexpected exception (no implicit conversion of Integer into String (TypeError)) on windows. So hold on 1.6.2 for a while.
See ruby/logger#107
Docs Changes:
N/A
Release Note:
N/A