This repository was archived by the owner on Dec 2, 2021. It is now read-only.
Adding the ability to control length to __format__#54
Open
WeiGodHorse wants to merge 1 commit intofluentpython:masterfrom
Open
Adding the ability to control length to __format__#54WeiGodHorse wants to merge 1 commit intofluentpython:masterfrom
WeiGodHorse wants to merge 1 commit intofluentpython:masterfrom
Conversation
Author
|
And I made some minor changes to the abs and bool functions. abs still uses 'math.hypot' as in Vector2d, while bool uses 'any'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I am a beginner of Python and github. I have just learned chapter 10 of Fluent Python. I noticed that in the last discussion section in chapter 10 you offered a little exercise in adding control over the length of output to the format method. I've just finished this exercise (although I feel like what I added looks jumbled) and added a few simple tests to the doctest (which may not be enough). I hope you can check whether the functions I added are correct. Meanwhile, I hope to take this opportunity to improve my python programming ability and practice the use of git and other functions. Thank you!