fix: support serverless logs and robust timeout in diagnose scripts

[Ayush-Patel-56]

Ⅰ. Describe what this PR does

Updates diagnostic scripts across all runtimes to support serverless mode and improve macOS compatibility.

Changes:

• Added log collection for Fuse sidecars in pods labeled serverless.fluid.io/inject=true.
• Updated the run helper to use gtimeout or perl as a fallback when GNU timeout is missing.
• Fixed a variable typo (fluid_namesapce) in the GooseFS script.

Ⅱ. Does this pull request fix one issue?

fixes #1852

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Manual verification of the timeout logic on systems without GNU coreutils. No tests needed for these standalone shell utilities.

Ⅳ. Describe how to verify it

1. Run any diagnostic script on macOS; it should now use the perl fallback instead of failing with command not found.
2. Run in a namespace with serverless workloads to verify sidecar logs are captured in the tarball.

Ⅴ. Special notes for reviews

Used a perl one-liner for the timeout fallback to keep the scripts dependency-free.

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fluid-e2e-bot]

Hi @Ayush-Patel-56. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gemini-code-assist]

Summary of Changes

Hello @Ayush-Patel-56, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the diagnostic scripts for Fluid runtimes by introducing support for collecting logs from serverless-enabled pods and improving the robustness of command timeouts. These changes ensure that diagnostic information can be gathered more comprehensively across different deployment environments and operating systems, particularly macOS, by providing alternative timeout mechanisms.

Highlights

• Serverless Log Collection: Added functionality to collect logs from fluid-fuse sidecar containers in serverless-labeled pods across all diagnostic scripts.
• Robust Timeout Mechanism: Implemented fallbacks for the timeout command, using gtimeout or a perl one-liner, to improve compatibility, especially on macOS.
• GooseFS Script Fix: Corrected a variable typo (fluid_namesapce to fluid_namespace) and improved string comparison in the GooseFS diagnostic script.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tools/diagnose-fluid-alluxio.sh
  • Updated the run function to use gtimeout or perl as a fallback for the timeout command.
  • Added serverless_pod_logs function to collect logs from fluid-fuse containers in serverless-labeled pods.
  • Integrated serverless_pod_logs into the main collection process.
• tools/diagnose-fluid-goosefs.sh
  • Updated the run function to use gtimeout or perl as a fallback for the timeout command.
  • Added serverless_pod_logs function to collect logs from fluid-fuse containers in serverless-labeled pods.
  • Fixed a typo in the core_component function, changing fluid_namesapce to fluid_namespace and using == for string comparison.
  • Integrated serverless_pod_logs into the main collection process.
• tools/diagnose-fluid-jindo.sh
  • Updated the run function to use gtimeout or perl as a fallback for the timeout command.
  • Added serverless_pod_logs function to collect logs from fluid-fuse containers in serverless-labeled pods.
  • Integrated serverless_pod_logs into the main collection process.
• tools/diagnose-fluid-juicefs.sh
  • Updated the run function to use gtimeout or perl as a fallback for the timeout command.
  • Added serverless_pod_logs function to collect logs from fluid-fuse containers in serverless-labeled pods.
  • Integrated serverless_pod_logs into the main collection process.

Activity

• The author manually verified the timeout logic on systems without GNU coreutils.
• The author suggested verifying the changes by running diagnostic scripts on macOS and in namespaces with serverless workloads.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the diagnostic scripts by adding support for serverless logs and improving timeout handling, particularly for macOS compatibility. The changes involve modifying the run function to use gtimeout or perl as fallbacks for timeout, adding a serverless_pod_logs function to collect logs from serverless pods, and incorporating this function into the pd_collect function in multiple shell scripts. Additionally, a typo in the GooseFS script has been fixed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud