Fix EGLNativeWindowType type compatibility with coregl update#162
Open
JSUYA wants to merge 2 commits intoflutter-tizen:masterfrom
Open
Fix EGLNativeWindowType type compatibility with coregl update#162JSUYA wants to merge 2 commits intoflutter-tizen:masterfrom
JSUYA wants to merge 2 commits intoflutter-tizen:masterfrom
Conversation
Update eglCreateWindowSurface call to properly cast tbm_surface_queue and egl_window to EGLNativeWindowType to match the updated coregl's eglplatform.h signature.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates eglCreateWindowSurface calls to fix a type compatibility issue with EGLNativeWindowType. The changes use reinterpret_cast to cast window handles to EGLNativeWindowType, adapting to an apparent change in the underlying type from a pointer to a handle. This fix is applied for both Wayland and NUI surface creation paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update eglCreateWindowSurface call to properly cast tbm_surface_queue and egl_window to EGLNativeWindowType to match the updated coregl's eglplatform.h signature.