[mustache_template] Add example app and code excerpts#11315
[mustache_template] Add example app and code excerpts#11315saudademjj wants to merge 3 commits intoflutter:mainfrom
Conversation
Create a runnable example app and readme_excerpts.dart with #docregion markers for all README code examples. Migrate inline README code blocks to the <?code-excerpt?> system for CI validation. Fixes flutter/flutter#183936
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request adds a runnable example application for the mustache_template package and migrates the code examples in README.md to use the <?code-excerpt?> system for CI validation. The changes also modernize the code style in the examples, fix existing errors in the README snippets, and remove a duplicated example. Overall, these changes improve the documentation and provide a helpful, runnable example for users. I have a couple of suggestions to align the new example code with the Dart style guide.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Closing to resubmit with code quality improvements based on review feedback. |
Adds a runnable example application and migrates all inline README code blocks to the
<?code-excerpt?>system for CI validation.example/lib/main.dartdemonstrating basic template rendering, nested paths, and lambdasexample/lib/readme_excerpts.dartwith#docregionmarkers for all 8 README code examplesvar→final/const, adds trailing commas, fixes syntax errors in original examplesmustache_templatefromtemp_exclude_excerpt.yamlFixes flutter/flutter#183936
Version-exempt: changes only affect unpublished example app (
publish_to: none) and README documentation.Test-exempt: documentation excerpt migration and example app addition only; all existing tests pass. Covered by "only affects comments or documentation" exemption.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2