[image_picker] Fix android-16 not picking up file#11320
[image_picker] Fix android-16 not picking up file#11320ashutosh2014 wants to merge 2 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses an issue on Android 16 (API 36) where the image picker would not return a file path. The solution is to enforce the use of the Android Photo Picker on API 36 and higher, which is implemented via a new utility method, effectiveUsePhotoPicker. This logic is consistently applied throughout the ImagePickerDelegate. The change is also accompanied by new unit tests, which is great. My review includes a minor suggestion to simplify the logic in the new utility method for improved conciseness.
...ge_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java
Show resolved
Hide resolved
Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the state of the PR as posted reflects the checklist please feel free to mark it as ready for review. |
|
This is the issue fixed by this current PR |
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with file selection on Android API 36+ by enforcing the use of the Android Photo Picker. The implementation introduces a new utility method and is accompanied by corresponding tests, which is great. My feedback focuses on improving the clarity of a new constant and associated comments to prevent potential confusion regarding Android versions and API levels.
| * Fixes gallery image/video selection on Android 16 (API 36) returning no paths when | ||
| `useAndroidPhotoPicker` was false. The plugin now uses the Android Photo Picker on API 36 and | ||
| above regardless of that flag, avoiding a broken `ACTION_GET_CONTENT` result from the system UI. |
There was a problem hiding this comment.
The reference to "Android 16 (API 36)" could be confusing, as Android version 16 doesn't correspond to API level 36. To improve clarity, consider referring to the API level directly.
| * Fixes gallery image/video selection on Android 16 (API 36) returning no paths when | |
| `useAndroidPhotoPicker` was false. The plugin now uses the Android Photo Picker on API 36 and | |
| above regardless of that flag, avoiding a broken `ACTION_GET_CONTENT` result from the system UI. | |
| * Fixes gallery image/video selection on Android API 36+ returning no paths when | |
| `useAndroidPhotoPicker` was false. The plugin now uses the Android Photo Picker on API 36 and | |
| above regardless of that flag, avoiding a broken `ACTION_GET_CONTENT` result from the system UI. |
| import java.util.Arrays; | ||
|
|
||
| final class ImagePickerUtils { | ||
| private static final int ANDROID_16_API_LEVEL = 36; |
There was a problem hiding this comment.
The constant name ANDROID_16_API_LEVEL is potentially misleading, as Android version 16 corresponds to API level 23 (Jelly Bean), not 36. A more generic name like API_LEVEL_36 would be clearer and avoid confusion. Please also update its usage within this file.
| private static final int ANDROID_16_API_LEVEL = 36; | |
| private static final int API_LEVEL_36 = 36; |
| * androidx.activity.result.contract.ActivityResultContracts.PickVisualMedia} (Android Photo | ||
| * Picker) instead of {@link android.content.Intent#ACTION_GET_CONTENT}. | ||
| * | ||
| * <p>On Android 16 (API 36), {@code ACTION_GET_CONTENT} for images may be handled by the system |
There was a problem hiding this comment.
The reference to "Android 16 (API 36)" is potentially confusing. To improve clarity, it would be better to refer to the API level directly.
| * <p>On Android 16 (API 36), {@code ACTION_GET_CONTENT} for images may be handled by the system | |
| * <p>On Android API 36+, {@code ACTION_GET_CONTENT} for images may be handled by the system |
|
@ashutosh2014 Please edit the PR description to include that information, along with the other requested information, instead of leaving placeholder text there and putting the requested information only in the comments. |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Fixes flutter/flutter#182071
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2