Skip to content

[two_dimensional_scrollables] Add debug check for pinning out of bounds#11366

Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom
Piinks:2d-136833
Mar 26, 2026
Merged

[two_dimensional_scrollables] Add debug check for pinning out of bounds#11366
auto-submit[bot] merged 5 commits intoflutter:mainfrom
Piinks:2d-136833

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 26, 2026

Fixes flutter/flutter#136833

This cleans up an old todo from when we added support for pinned rows and columns to TableView. It is possible for the pinned extents to exceed the viewport bounds, which would make scrolling impossible, and unpinned rows/columns inaccessible. This adds debug check during layout to catch this now.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions bot added p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package triage-framework Should be looked at in framework triage labels Mar 26, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the two_dimensional_scrollables package to version 0.4.1, introducing debug warnings for TableView when pinned rows or columns exceed or fully occupy the viewport dimensions. These warnings help identify configurations where unpinned content would be invisible. The changes include the implementation of _debugCheckPinnedExtent and a new suite of regression tests. Feedback suggests refactoring the tests to use setUp and tearDown for mocking debugPrint to reduce code duplication and improve maintainability.

@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Mar 26, 2026
@Piinks Piinks added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 26, 2026
@Piinks Piinks added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Mar 26, 2026
@auto-submit auto-submit bot merged commit 049cc84 into flutter:main Mar 26, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[two_dimensional_scrollables] TableView pinned rows and columns should warn if pinned spans exceed viewport dimensions

2 participants