Fix/12650

[MoritzMessner]

Description of what this PR is changing or adding, and why:

search bars have different styling, align searchs bars for consistency

Issues fixed by this PR (if any):
#12650

PRs or commits this PR depends on (if any):
mobile:

wide:

Presubmit checklist

• If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
• If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
• This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
• This PR uses semantic line breaks
  of 80 characters or fewer.

[gemini-code-assist]

Summary of Changes

Hello @MoritzMessner, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the implementation and styling of search bars across the site to achieve greater consistency and reusability. It centralizes search bar CSS definitions and introduces a dedicated SearchBar component in Dart, which is then adopted by existing pages. This change streamlines future maintenance and ensures a uniform user experience for search functionalities.

Highlights

• Centralized Search Bar Styling: Moved search bar-related CSS rules from page-specific stylesheets to a common _filter-search.scss file to ensure consistent appearance across the site.
• Reusable SearchBar Component: Introduced a new SearchBar Dart component in search.dart to encapsulate search input functionality and styling, promoting code reusability.
• Enhanced SearchBar Flexibility: Added trailing and id properties to the SearchBar component, allowing for custom elements next to the search input and unique identification for styling or scripting.
• Migration to New Component: Updated the learning resources page (learning_resource_filters.dart) to utilize the new SearchBar component, replacing its previous inline implementation and adopting the standardized approach.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great refactoring effort to unify the styling and implementation of search bars across the site. By creating a reusable SearchBar component and centralizing the SCSS styles, you've reduced code duplication and improved maintainability. The changes are well-executed and align with the goal of achieving a consistent look and feel. I have one minor suggestion to make the SCSS even cleaner.

[parlough]

/gcbrun

[flutter-website-bot]

Visit the preview URL for this PR (updated for commit 20ce83b):

https://flutter-docs-prod--pr13008-fix-12650-7p54bd5f.web.app

[sfshaza2]

This looks ok to me but, @schultek, can you review?

[schultek]

LGTM, just one nitpick.

[sfshaza2]

@MoritzMessner, can you sign the CLA? I can land until you've signed. thx

[MoritzMessner]

@MoritzMessner, can you sign the CLA? I can land until you've signed. thx

@sfshaza2
i think i've singed it already and did pr's in the past. Could you maybe double check?

[schultek]

@MoritzMessner, can you sign the CLA? I can land until you've signed. thx

It was me (on a different email), fixed

[schultek]

/gcbrun

[sfshaza2]

lgtm