Also fix versionName in example build.gradle.kts#13203
Also fix versionName in example build.gradle.kts#13203solsticedhiver wants to merge 3 commits intoflutter:mainfrom
Conversation
There is a call to .toInteger() on flutter.versionCode in the example of build.gradle.kts This does not seem right because that change throws an error when trying to build the app with that change. Note: I don't see such a call to .toInterger() with the build.gradle.kts created with flutter for a brand new app
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue in the Android deployment documentation where a code example for build.gradle.kts used invalid Groovy syntax (.toInteger()) within a Kotlin script context. The change removes this incorrect method call. My review includes a suggestion to further improve the example for consistency by using properties from the flutter Gradle extension, which aligns with other parts of the same code snippet and modern Flutter project configurations.
|
Oops I have signed the CLA after clicking the button. should be ok now |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There is a call to .toInteger() on flutter.versionCode in the example of build.gradle.kts
This does not seem right because that change throws an error when trying to build the app with that change.
Note: There is no such a call to .toInteger() with the build.gradle.kts created with flutter for a brand new app
Description of what this PR is changing or adding, and why:
Remove a call to to toInteger() for flutter.versionCode because it throws an error when building and does not seem necessary (builds fine without)
Issues fixed by this PR (if any):
See above
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.