Route chart name changes through upgrade instead of uninstall/reinstall#1451
Closed
mattnewell wants to merge 1 commit intofluxcd:mainfrom
Closed
Route chart name changes through upgrade instead of uninstall/reinstall#1451mattnewell wants to merge 1 commit intofluxcd:mainfrom
mattnewell wants to merge 1 commit intofluxcd:mainfrom
Conversation
Chart name changes do not affect the Helm storage key (release name + namespace), so they can be handled by the existing upgrade path which correctly diffs old and new manifests. The uninstall/reinstall cycle causes unnecessary downtime by deleting all resources before recreating them. VerifyRelease() already detects chart name changes via ErrChartChanged, routing them to ReleaseStatusOutOfSync and an upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Matt Newell <matt.newell@brivo.com>
Member
|
Duplicate of #1447. Please refer to the discussion there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseTargetChanged(), causing unnecessary downtime by deleting all resources before recreating themhelm upgradecorrectly diffs old and new manifests, removing resources no longer in the new chartVerifyRelease()already detects chart name changes viaErrChartChanged, routing them toReleaseStatusOutOfSyncand the upgrade path — so the fallback behavior is already in placeTest plan
TestReleaseTargetChangedto assert chart name change returnsfalsemake test)🤖 Generated with Claude Code