Skip to content

docs: rewrite ADR-0007-impl as proper ADR to fix docs build #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flyingrobots wants to merge 4 commits into
base: main
Choose a base branch
from
+686 −3,155
Open

docs: rewrite ADR-0007-impl as proper ADR to fix docs build #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
246eab2
fix(ci): derive DET-001 evidence from static-inspection.json status
flyingrobots Feb 22, 2026
b14b3c7
docs: rewrite ADR-0007-impl as proper ADR to fix docs build
flyingrobots Feb 22, 2026
c4d1ddb
docs: add CHANGELOG entry for ADR-0007-impl rewrite
flyingrobots Feb 22, 2026
896c205
chore: Remove auditing script
flyingrobots Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@

## Unreleased

### Fixed (Docs)

- **Docs Build:** Rewrote `ADR-0007-impl.md` from a 3185-line raw conversation
transcript into a proper 13-section ADR document. The Vue template compiler
was crashing on bare Rust generics (`BTreeMap<NodeId, NodeRecord>`, etc.)
outside fenced code blocks. The new document preserves all architectural
knowledge as a structured implementation companion to ADR-0007.
Comment on lines +8 to +14
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Missing CHANGELOG entry for the DET-001 CI evidence derivation fix.

This PR contains three commits, but only Commit 2 (the docs rewrite) is reflected here. Commit 1 — fix(ci): Adjusts DET-001 evidence derivation to parse static-inspection.json — is a behavioral change to how claim evidence is computed and should have its own entry. This project's own changelog discipline (50+ granular entries in [0.1.3] alone) treats every CI/governance behavioral delta as a first-class event. Silently omitting a change to evidence integrity logic in a project whose entire governance model is built around evidence integrity is contradictory.

Suggested addition under ## Unreleased:

+### Fixed (CI)
+
+- **Evidence Derivation:** Replaced artifact-directory-presence check for `DET-001` with
+  structured parsing and validation of `static-inspection.json`; `FAILED` static inspections
+  now correctly yield `UNVERIFIED` evidence instead of relying solely on artifact existence.
+  Adds `source_file`, `source_status`, and optional `error` fields to DET-001 evidence.
+
 ### Fixed (Docs)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### Fixed (Docs)
- **Docs Build:** Rewrote `ADR-0007-impl.md` from a 3185-line raw conversation
transcript into a proper 13-section ADR document. The Vue template compiler
was crashing on bare Rust generics (`BTreeMap<NodeId, NodeRecord>`, etc.)
outside fenced code blocks. The new document preserves all architectural
knowledge as a structured implementation companion to ADR-0007.
### Fixed (CI)
- **Evidence Derivation:** Replaced artifact-directory-presence check for `DET-001` with
structured parsing and validation of `static-inspection.json`; `FAILED` static inspections
now correctly yield `UNVERIFIED` evidence instead of relying solely on artifact existence.
Adds `source_file`, `source_status`, and optional `error` fields to DET-001 evidence.
### Fixed (Docs)
- **Docs Build:** Rewrote `ADR-0007-impl.md` from a 3185-line raw conversation
transcript into a proper 13-section ADR document. The Vue template compiler
was crashing on bare Rust generics (`BTreeMap<NodeId, NodeRecord>`, etc.)
outside fenced code blocks. The new document preserves all architectural
knowledge as a structured implementation companion to ADR-0007.
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` around lines 8 - 14, Add a missing Unreleased entry to
CHANGELOG.md describing Commit 1: "fix(ci): Adjusts DET-001 evidence derivation
to parse static-inspection.json"; mention DET-001, that evidence derivation now
parses static-inspection.json (instead of previous source) and the impact on
claim evidence computation, and place it under the "## Unreleased" heading
alongside the existing docs entry so the CI/governance behavioral change is
recorded.


## [0.1.3] — 2026-02-21

### Fixed (Sprint S1)
Expand Down
Loading
Loading