forked from OpenStackweb/summit-admin
-
Notifications
You must be signed in to change notification settings - Fork 4
feature: add and edit custom sponsor page #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomrndom
wants to merge
6
commits into
feature/sponsor-page-tab-managed-popup
Choose a base branch
from
feature/sponsor-tab-custom-add
base: feature/sponsor-page-tab-managed-popup
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
52fd277
fix: addnig header
santipalenque 8a8e2ed
feat: wip add sponsor custom page
tomrndom ee5a4f5
fix: add component for add ons on page popup, adjust reducer and actions
tomrndom a0bea4f
feat: add edit functionality for customized sponsor pages
tomrndom b32d1d2
fix: add test cases for add and edit customized pages
tomrndom 9e4d822
fix: adjust fields on actions, fix formik text editor functions
tomrndom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
.finally()on POST request will leave loading spinner on error.The PUT request (lines 304-322) correctly uses
.finally()to callstopLoading(), but the POST request dispatchesstopLoading()inside.then(). If the POST request fails, the loading spinner will remain indefinitely.Proposed fix: Move stopLoading to a .finally() block
return postRequest( null, createAction(SPONSOR_CUSTOMIZED_PAGE_ADDED), `${window.SPONSOR_PAGES_API_URL}/api/v1/summits/${currentSummit.id}/sponsors/${sponsorId}/sponsor-pages`, normalizedEntity, snackbarErrorHandler - )(params)(dispatch).then(() => { - dispatch(stopLoading()); + )(params)(dispatch) + .then(() => { dispatch( snackbarSuccessHandler({ title: T.translate("general.success"), html: T.translate("edit_sponsor.pages_tab.custom_page_created") }) ); - }); + }) + .finally(() => { + dispatch(stopLoading()); + }); };📝 Committable suggestion
🤖 Prompt for AI Agents