forked from OpenStackweb/summit-admin
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: fields for opens at and expires at on new form marked as mandatory #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
priscila-moneo
wants to merge
1
commit into
master
Choose a base branch
from
fix/new-form-mark-mandatory-fields
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
src/components/mui/__tests__/mui-formik-datepicker.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import React from "react"; | ||
| import { render, screen, waitFor } from "@testing-library/react"; | ||
| import userEvent from "@testing-library/user-event"; | ||
| import { Formik, Form } from "formik"; | ||
| import "@testing-library/jest-dom"; | ||
| import MuiFormikDatepicker from "../formik-inputs/mui-formik-datepicker"; | ||
|
|
||
| const renderWithFormik = (props, initialValues = { test_date: null }) => | ||
| render( | ||
| <Formik | ||
| initialValues={initialValues} | ||
| validate={(values) => { | ||
| const errors = {}; | ||
| if (!values.test_date) { | ||
| errors.test_date = "This field is required"; | ||
| } | ||
| return errors; | ||
| }} | ||
| onSubmit={jest.fn()} | ||
| > | ||
| <Form> | ||
| <MuiFormikDatepicker name="test_date" label="Test Date" {...props} /> | ||
| </Form> | ||
| </Formik> | ||
| ); | ||
|
|
||
| describe("MuiFormikDatepicker", () => { | ||
| test("shows required marker in label", () => { | ||
| renderWithFormik({ required: true }); | ||
|
|
||
| expect(screen.getByLabelText("Test Date *")).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test("shows validation error when blurring without value", async () => { | ||
| renderWithFormik({ required: true }); | ||
|
|
||
| expect( | ||
| screen.queryByText("This field is required") | ||
| ).not.toBeInTheDocument(); | ||
|
|
||
| const user = userEvent.setup(); | ||
| const input = screen.getByLabelText("Test Date *"); | ||
| await user.click(input); | ||
| await user.tab(); | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.getByText("This field is required")).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,15 +8,21 @@ import { useField } from "formik"; | |
| const MuiFormikDatepicker = ({ name, label, required, ...props }) => { | ||
| const [field, meta, helpers] = useField(name); | ||
| const requiredLabel = `${label} *`; | ||
| const handleBlur = () => { | ||
| helpers.setTouched(true, true); | ||
| }; | ||
|
|
||
| return ( | ||
| <LocalizationProvider dateAdapter={AdapterMoment}> | ||
| <DatePicker | ||
| value={field.value} | ||
| onChange={helpers.setValue} | ||
| onClose={handleBlur} | ||
| slotProps={{ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT: Since this is out of the scope of this PR I will just call it out: If a caller passes slotProps through ...props, it will override this entire object, breaking the wrapper. @caseylocker @smarcet For you consideration. |
||
| textField: { | ||
| name, | ||
| label: required ? requiredLabel : label, | ||
| onBlur: handleBlur, | ||
| error: meta.touched && Boolean(meta.error), | ||
| helperText: meta.touched && meta.error, | ||
| fullWidth: true | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only asserts the error appears. It does not prove the blur caused it.
expect(screen.queryByText("This field is required")).not.toBeInTheDocument();Before the interaction to be explicit.