Skip to content

fix: update company field from email attendee, catch error on resend #816

Open
tomrndom wants to merge 1 commit intomasterfrom
fix/ticket-form-company-resend
Open

fix: update company field from email attendee, catch error on resend #816
tomrndom wants to merge 1 commit intomasterfrom
fix/ticket-form-company-resend

Conversation

@tomrndom
Copy link

@tomrndom tomrndom commented Mar 6, 2026

ref: https://app.clickup.com/t/86b8t1qy7

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • New Features

    • Owner company information now automatically synchronizes when ticket ownership is assigned.
  • Bug Fixes

    • Ticket email resend prevented for tickets without assigned owner; users receive warning message before attempting resend.
  • Localization

    • Added localized message for unassigned ticket status.

…not assigned tickets

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet March 6, 2026 21:06
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a597bbac-3911-4697-a1a0-d1200405802c

📥 Commits

Reviewing files that changed from the base of the PR and between 827fd4a and 00bc553.

📒 Files selected for processing (3)
  • src/components/forms/ticket-form.js
  • src/i18n/en.json
  • src/pages/orders/edit-ticket-page.js

📝 Walkthrough

Walkthrough

The PR enhances ticket owner assignment validation across form handling, email operations, and localization. It adds synchronous updates for attendee company during owner input changes, implements a guard preventing email resend when no ticket owner exists, and introduces a translation key for unassigned ticket messaging.

Changes

Cohort / File(s) Summary
Ticket Owner Input & Validation
src/components/forms/ticket-form.js, src/pages/orders/edit-ticket-page.js
Adds ownerinput field handling to sync attendee_company with owner input, and introduces email resend guard requiring assigned ticket owner before proceeding.
Localization
src/i18n/en.json
Adds translation key edit_ticket.no_attendee for displaying unassigned ticket message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • smarcet

Poem

🐰 A ticket needs an owner true,
No ghostly assignments will do!
Now forms sync attendee with care,
And emails guard against thin air—
One message tells when none are there! 📧✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updating company field from email attendee and catching errors on resend email, matching the modifications in ticket-form.js, en.json, and edit-ticket-page.js.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ticket-form-company-resend

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant