Refactor function to render multiple ticket text, fix multiple types#104
Open
Refactor function to render multiple ticket text, fix multiple types#104
Conversation
smarcet
reviewed
Oct 23, 2024
src/components/ticket-owned/index.js
Outdated
| return ` | ||
| ${acc}${acc ? `${index+1===ownedTickets.length? ' and ' : ', '}` : ''} | ||
| ${ownedTicket.qty} ${ownedTicket.type_name}${index === 0 ? !ownedTicket.type_name.toLowerCase().endsWith('ticket') ? ' ticket' : '' : ownedTicket.type_name.toLowerCase().endsWith('ticket') ? '' : ''}${ownedTicket.qty > 1 ? 's' : ''}`; | ||
| const lastTicket = index + 1 === ownedTickets.length; |
Collaborator
There was a problem hiding this comment.
could u extract this logic to a helper method and create the proper unit tests ?
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
tomrndom
force-pushed
the
hotfix/ticket-owned-improvements
branch
from
8ceb3c1 to
b07abde
Compare
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://tipit.avaza.com/task#!sortby=DateUpdatedDesc&task=2954594
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com