Fix the Variation Selector handling#278
Open
KojiAndoJC wants to merge 2 commits intofoliojs:masterfrom
Open
Conversation
Fix the problem that the variable `i` was overwritten and the non-default UVS wasn't used when the default UVS exists.
devongovett
reviewed
May 25, 2022
Member
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
Thanks. Alternatively, you could make i within the if statement block scoped (via let), so it isn't overwritten?
| i = binarySearch(sel.defaultUVS, x => | ||
| codepoint < x.startUnicodeValue ? -1 : codepoint > x.startUnicodeValue + x.additionalCount ? +1 : 0 | ||
| ); | ||
| if (i !== -1) { |
Member
There was a problem hiding this comment.
Should this be the opposite, i.e. i === -1?
Author
There was a problem hiding this comment.
I'm sorry I didn't make it clear enough. My pull request fixes two problems.
- When the default UVS table exists and its entry not exists (
i === -1), the variableiwas overwriten and the non-default UVS isn't used. - When the default entry exists (
i !== -1), it means "the default glyph (the same glyph as base character) should be used" and checking the non-default UVS is unnecessary. By returning 0, the Variation Selector is ignored correctly here.
Member
There was a problem hiding this comment.
A test would help understanding the issue and ensuring the fix is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the problem that the variable
iwas overwritten and the non-default UVS wasn't used when the default UVS exists.