refactor: replace crypto-js #1681
Merged
blikblum merged 4 commits intofoliojs:masterfrom Jan 30, 2026
Merged
Conversation
Member
|
Do you have an estimate what is the build size difference? |
Contributor
Author
|
@blikblum Good question.
4.2% reduction in |
Member
|
What matters is the standalone because the others do not include the dependencies. So the build size will be smaller when bundling in browser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Closes #1637
Library Selection for crypto-js Replacement
Instead of large polyfill like crypto-browserify, I selected small, purpose-built libraries that cover what PDFKit needs.
And mainly because
@noble/*does not provided MD5 which is no longer secureNo actively maintained RC4 lib with browser support found 😭
Note that Web Crypto API provides SHA-256 digest and AES-CBC encryption but via asynchronous interface, which requires a big breaking change 💣
Checklist: