@W-21717256 Adding completing callback to resetSessionCookie()#4008
Merged
wmathurin merged 1 commit intoforcedotcom:devfrom Mar 24, 2026
Merged
@W-21717256 Adding completing callback to resetSessionCookie()#4008wmathurin merged 1 commit intoforcedotcom:devfrom
wmathurin merged 1 commit intoforcedotcom:devfrom
Conversation
That will allow us to fix the race condition causing infinite login loop in hybrid auth (where we call resetSessionCookie before setting cookies)
|
||||||||||||||||||||||
|
||||||||||||||||||
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #4008 +/- ##
==========================================
- Coverage 68.54% 67.22% -1.33%
==========================================
Files 253 253
Lines 22289 22337 +48
==========================================
- Hits 15278 15016 -262
- Misses 7011 7321 +310
🚀 New features to boost your workflow:
|
|
||||||||||||||||||
wmathurin
commented
Mar 24, 2026
| @@ -53,13 +53,21 @@ public class SFSDKWebViewStateManager: NSObject { | |||
| @objc | |||
| @MainActor | |||
| public static func resetSessionCookie() { | |||
Contributor
Author
There was a problem hiding this comment.
In 13.0.0 and earlier this method was implemented as follow
+ (void)resetSessionCookie {
if (_sessionCookieManagementDisabled) {
[SFSDKCoreLogger d:self format:@"[%@ %@]: Cookie Management disabled. Will do nothing.", NSStringFromClass(self), NSStringFromSelector(_cmd)];
return;
}
[self removeWKWebViewCookies];
}As a result, there was no race conditions calling resetSessionCookie and then calling setCookies.
bbirman
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That will allow us to fix the race condition causing infinite login loop in hybrid auth (where we call resetSessionCookie before setting cookies)