Skip to content

CMS Search Skills#63

Closed
thrylokya wants to merge 30 commits intoforcedotcom:mainfrom
thrylokya:main
Closed

CMS Search Skills#63
thrylokya wants to merge 30 commits intoforcedotcom:mainfrom
thrylokya:main

Conversation

@thrylokya
Copy link
Copy Markdown
Contributor

References: Contributing guide · Skill authoring guide · Agent Skills spec

What changed

Why

Notes


Skills

Manual checklist

Description quality

  • Describes what the skill does and the expected output
  • Includes relevant Salesforce domain keywords (Apex, LWC, SOQL, metadata types, etc.)
  • Trigger phrases are specific enough for Vibes to select this skill reliably

Instructions

  • Clear goal statement
  • Step-by-step workflow
  • Validation rules for generated output
  • Defined output / artifact

Context efficiency

  • Core instructions are concise — supporting material lives in templates/, examples/, or docs/ subdirectories
  • No unnecessary background explanation in the body

Automated checks

Enforced by CI (npm run validate:skills) per the Agent Skills spec:

  • Directory is one level deep, named in kebab-case (max 64 chars), contains SKILL.md
  • Frontmatter name matches directory name; description is present, ≥ 20 words, ≤ 1024 characters, and includes trigger language
  • Body is non-empty and under 500 lines
  • Name uses gerund form ⚠ (warning — does not block merge)

Comment thread skills/SKILL.md Outdated
@@ -0,0 +1,86 @@
---
name: cms-media-options
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not following proper skill directly structure and please make sure validate_skill check passes in the PR.

Comment thread skills/SKILL.md Outdated
---
name: cms-media-options
description: REQUIRED entry point for ALL media and image searches. Every request to find, search, locate, retrieve, browse, get, look up, or use images, photos, pictures, media, icons, illustrations, hero images, banners, thumbnails, logos MUST go through this skill first. Checks which search sources are available, presents only those options, and delegates to the appropriate search skill based on the user's choice. Never search for media directly — always start here.
license: Apache-2.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this license.

Comment thread skills/SKILL.md Outdated
license: Apache-2.0
compatibility: Python 3.x or Python 2.7+ recommended, bash 3.2+ (Git Bash/WSL on Windows). Cross-platform: Mac, Windows (Git Bash/WSL), Linux, POSIX.
metadata:
author: afv-library
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove author.

Comment thread skills/build_cms_search_input.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the folder structure here: https://agentskills.io/specification
Put scripts in the scripts/ folder.

Move stuff from your rules file into SKILL.md. You only want a skill, not a rule. You can also break down your skill.md file into multiple markdown files. The main markdown is in SKILL.md while the other markdown files can be in the references folder and referred from SKILL.md

Comment thread skills/cms-d360-search/SKILL.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the skill naming conventions here
"Skill names should use gerund form (verbs ending in “-ing”). Gerund-based names create a clear and readable skill library. "
So, perhaps your this skill name can be something like "searching-cms-d360" or some such. Similarly, change the name of the other 2 skills.

Comment thread skills/cms-d360-search/SKILL.md Outdated
@@ -0,0 +1,40 @@
---
name: cms-d360-search
description: Data Cloud AI Hybrid Search via search_electronic_media or search_content_in_d360 MCP tool. Performs semantic search across Salesforce CMS and 3rd-party DAMs using natural language queries. Invoked from cms-media-search when the user selects Data Cloud – AI Hybrid Search.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thrylokya is there any reason for mentioning search_content_in_d360? our tool is search_electronic_media

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skesanthosh : I am not going to merge this right away. So, there are 2 approaches I am trying. First, is to have a modular one and see if skills are rightly invoked from another skill. Based on our observations, this is not happening too consistently.
The other approach is to have the entire functionality in one skill making it less modular. Based on how our Blitz goes, we will decide on teh approach.
On the naming convention, I already asked Alex for the labels. Once she is back with her suggestions, I can merge them.

Comment thread skills/cms-d360-search/SKILL.md Outdated

Semantic search across Salesforce CMS and connected 3rd-party DAMs. Invoked by `cms-media-search` when the user selects **Data Cloud – AI Hybrid Search**.

Best for natural language queries, cross-system searches, and semantic similarity (vs exact keyword matching).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hybrid Search includes both Vector/Semantic + Keyword based matching

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our observations, a skill invoking from another skill is not happening too consistently(this we observed in blitz). So just trying out various options.

Comment thread skills/cms-d360-search/SKILL.md Outdated
@@ -0,0 +1,40 @@
---
name: cms-d360-search
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not have cms prefix for this skill, we didn't have it in the tool name either

Comment thread skills/cms-d360-search/SKILL.md Outdated
@@ -0,0 +1,40 @@
---
name: cms-d360-search
description: Data Cloud AI Hybrid Search via search_electronic_media or search_content_in_d360 MCP tool. Performs semantic search across Salesforce CMS and 3rd-party DAMs using natural language queries. Invoked from cms-media-search when the user selects Data Cloud – AI Hybrid Search.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: "Invoked from cms-media-search when the user selects Data Cloud – AI Hybrid Search." is this required in description?

Comment thread skills/cms-d360-search/SKILL.md Outdated

Input: `query` = the user's search query string. Refer to the tool's schema for additional parameters.

## Step 3: Present Results and Handle Selection
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, are we having this skill just for this step 3? because the tool description and input schema are enough for invoking the tool with right parameters.

@thrylokya thrylokya closed this by deleting the head repository Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants