Conversation
| @@ -0,0 +1,86 @@ | |||
| --- | |||
| name: cms-media-options | |||
There was a problem hiding this comment.
This PR is not following proper skill directly structure and please make sure validate_skill check passes in the PR.
| --- | ||
| name: cms-media-options | ||
| description: REQUIRED entry point for ALL media and image searches. Every request to find, search, locate, retrieve, browse, get, look up, or use images, photos, pictures, media, icons, illustrations, hero images, banners, thumbnails, logos MUST go through this skill first. Checks which search sources are available, presents only those options, and delegates to the appropriate search skill based on the user's choice. Never search for media directly — always start here. | ||
| license: Apache-2.0 |
There was a problem hiding this comment.
Please remove this license.
| license: Apache-2.0 | ||
| compatibility: Python 3.x or Python 2.7+ recommended, bash 3.2+ (Git Bash/WSL on Windows). Cross-platform: Mac, Windows (Git Bash/WSL), Linux, POSIX. | ||
| metadata: | ||
| author: afv-library |
There was a problem hiding this comment.
Follow the folder structure here: https://agentskills.io/specification
Put scripts in the scripts/ folder.
Move stuff from your rules file into SKILL.md. You only want a skill, not a rule. You can also break down your skill.md file into multiple markdown files. The main markdown is in SKILL.md while the other markdown files can be in the references folder and referred from SKILL.md
There was a problem hiding this comment.
Please follow the skill naming conventions here
"Skill names should use gerund form (verbs ending in “-ing”). Gerund-based names create a clear and readable skill library. "
So, perhaps your this skill name can be something like "searching-cms-d360" or some such. Similarly, change the name of the other 2 skills.
| @@ -0,0 +1,40 @@ | |||
| --- | |||
| name: cms-d360-search | |||
| description: Data Cloud AI Hybrid Search via search_electronic_media or search_content_in_d360 MCP tool. Performs semantic search across Salesforce CMS and 3rd-party DAMs using natural language queries. Invoked from cms-media-search when the user selects Data Cloud – AI Hybrid Search. | |||
There was a problem hiding this comment.
@thrylokya is there any reason for mentioning search_content_in_d360? our tool is search_electronic_media
There was a problem hiding this comment.
@skesanthosh : I am not going to merge this right away. So, there are 2 approaches I am trying. First, is to have a modular one and see if skills are rightly invoked from another skill. Based on our observations, this is not happening too consistently.
The other approach is to have the entire functionality in one skill making it less modular. Based on how our Blitz goes, we will decide on teh approach.
On the naming convention, I already asked Alex for the labels. Once she is back with her suggestions, I can merge them.
|
|
||
| Semantic search across Salesforce CMS and connected 3rd-party DAMs. Invoked by `cms-media-search` when the user selects **Data Cloud – AI Hybrid Search**. | ||
|
|
||
| Best for natural language queries, cross-system searches, and semantic similarity (vs exact keyword matching). |
There was a problem hiding this comment.
Hybrid Search includes both Vector/Semantic + Keyword based matching
There was a problem hiding this comment.
Based on our observations, a skill invoking from another skill is not happening too consistently(this we observed in blitz). So just trying out various options.
| @@ -0,0 +1,40 @@ | |||
| --- | |||
| name: cms-d360-search | |||
There was a problem hiding this comment.
I think we should not have cms prefix for this skill, we didn't have it in the tool name either
| @@ -0,0 +1,40 @@ | |||
| --- | |||
| name: cms-d360-search | |||
| description: Data Cloud AI Hybrid Search via search_electronic_media or search_content_in_d360 MCP tool. Performs semantic search across Salesforce CMS and 3rd-party DAMs using natural language queries. Invoked from cms-media-search when the user selects Data Cloud – AI Hybrid Search. | |||
There was a problem hiding this comment.
Minor: "Invoked from cms-media-search when the user selects Data Cloud – AI Hybrid Search." is this required in description?
|
|
||
| Input: `query` = the user's search query string. Refer to the tool's schema for additional parameters. | ||
|
|
||
| ## Step 3: Present Results and Handle Selection |
There was a problem hiding this comment.
Just wondering, are we having this skill just for this step 3? because the tool description and input schema are enough for invoking the tool with right parameters.
References: Contributing guide · Skill authoring guide · Agent Skills spec
What changed
Why
Notes
Skills
Manual checklist
Description quality
Instructions
Context efficiency
templates/,examples/, ordocs/subdirectoriesAutomated checks
Enforced by CI (
npm run validate:skills) per the Agent Skills spec:SKILL.mdnamematches directory name;descriptionis present, ≥ 20 words, ≤ 1024 characters, and includes trigger language