Skip to content

refactor(build): use SPDX license expression in pyproject.toml#262

Merged
soimkim merged 1 commit intomainfrom
py
Mar 20, 2026
Merged

refactor(build): use SPDX license expression in pyproject.toml#262
soimkim merged 1 commit intomainfrom
py

Conversation

@soimkim
Copy link
Copy Markdown
Contributor

@soimkim soimkim commented Mar 19, 2026

Description

Updated project configuration metadata, including simplification of the license field format in project settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1940ed23-fd0c-4c03-ba99-301125cb43f3

📥 Commits

Reviewing files that changed from the base of the PR and between 5c6acc1 and 0cec7e0.

📒 Files selected for processing (1)
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

Updated pyproject.toml: increased build-system setuptools requirement, changed project license from table to string form, and removed the Apache license classifier entry.

Changes

Cohort / File(s) Summary
Project metadata
pyproject.toml
Bumped [build-system].requires setuptools>=61setuptools>=77; changed [project].license from { text = "Apache-2.0" } to "Apache-2.0"; removed "License :: OSI Approved :: Apache Software License" from [project].classifiers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • fosslight/fosslight_source_scanner#260: Also modifies pyproject.toml build/project metadata including setuptools requirement and license/classifier adjustments.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updating license handling from a table form to an SPDX expression, and increasing setuptools version requirement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch py
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@soimkim soimkim self-assigned this Mar 19, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Mar 19, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Line 13: The pyproject.toml uses an SPDX license string (license =
"Apache-2.0") but build-system.requires still allows setuptools>=61 which does
not fully support PEP 639; update the build-system.requires entry to require
setuptools>=77.0.0 (e.g., replace or bump the "setuptools>=61" requirement to
"setuptools>=77.0.0", preserving any other build-system.requires entries like
"wheel") so the SPDX metadata is parsed correctly during builds.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eb00f59a-1af4-48ad-890d-b95229ad9627

📥 Commits

Reviewing files that changed from the base of the PR and between e909989 and 5c6acc1.

📒 Files selected for processing (1)
  • pyproject.toml

@soimkim soimkim merged commit 3aa8813 into main Mar 20, 2026
7 checks passed
@soimkim soimkim deleted the py branch March 20, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant