Draft
Conversation
Author
|
The server currently compiles and runs, but I haven't tested it with a non-empty mailbox. Is there an easy way to generate/import test data for that purpose? |
kiwiz
commented
Mar 2, 2025
internal/endpoint/pop3/pop3.go
Outdated
| // client is greater than than the number of lines in the | ||
| // body, then the POP3 server sends the entire message. | ||
| func (endp *Endpoint) Top(user pop3backend.User, msgId int, n int) (lines []string, err error) { | ||
| return nil, fmt.Errorf("pop3: unimplemented") |
Author
There was a problem hiding this comment.
Is there code I can reference for formatting the message headers?
Owner
There was a problem hiding this comment.
Hmm, that one is tricky. I guess, you would need to consume Literals returned by ListMessages and format them yourself. It is okay to partially consume returned value.
kiwiz
commented
Mar 2, 2025
kiwiz
commented
Mar 16, 2025
|
|
||
| replace github.com/libdns/gandi => github.com/foxcpp/libdns-gandi v1.0.4-0.20240127130558-4782f9d5ce3e // v1.0.3+maddy.1 | ||
|
|
||
| replace github.com/kiwiz/popgun v0.0.0 => ../popgun |
Author
There was a problem hiding this comment.
These references will need to be updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the POP3 protocol. A lot of work is still needed, but I wanted to get some early feedback on the direction I'm taking. The code was based off
imap, so there may be some dead code remaining.Implements #650