Expand integration test coverage: NON_VIRTUAL_NETTY and mockless modes#100
Draft
Copilot wants to merge 2 commits intomode_simplifiedfrom
Draft
Expand integration test coverage: NON_VIRTUAL_NETTY and mockless modes#100Copilot wants to merge 2 commits intomode_simplifiedfrom
Copilot wants to merge 2 commits intomode_simplifiedfrom
Conversation
Co-authored-by: franz1981 <13125299+franz1981@users.noreply.github.com> Agent-Logs-Url: https://github.com/franz1981/Netty-VirtualThread-Scheduler/sessions/29c803da-efaf-4bd1-84ed-265e036036ea
Copilot
AI
changed the title
[WIP] Simplify benchmark runner
Expand integration test coverage: NON_VIRTUAL_NETTY and mockless modes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests only exercised
VIRTUAL_NETTYwith a live mock server, leavingNON_VIRTUAL_NETTYand the mockless code path entirely untested. This is the codified verification that mockless behavior is correct and equivalent across modes.Changes
Expanded test matrix —
serverConfigurations()now covers four combinations:VIRTUAL_NETTY+ mock server (existing)NON_VIRTUAL_NETTY+ mock serverVIRTUAL_NETTY+ mocklessNON_VIRTUAL_NETTY+ mocklessstartServersacceptsmocklessflag — the mock server is always started (so mock-server tests work uniformly), but the handoff server skips the HTTP call whenmockless=true, exercisingdoMocklessProcessingdirectlyTest display names promoted to arg
{3}— description index updated to match the new 4-argumentArgumentstuplesJavadoc updated — notes that
NETTY_SCHEDULERis excluded because it requires-Djdk.virtualThreadScheduler.implClass=io.netty.loom.NettyScheduler📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.