Skip to content

Expand integration test coverage: NON_VIRTUAL_NETTY and mockless modes#100

Draft
Copilot wants to merge 2 commits intomode_simplifiedfrom
copilot/sub-pr-97-again
Draft

Expand integration test coverage: NON_VIRTUAL_NETTY and mockless modes#100
Copilot wants to merge 2 commits intomode_simplifiedfrom
copilot/sub-pr-97-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 23, 2026

Integration tests only exercised VIRTUAL_NETTY with a live mock server, leaving NON_VIRTUAL_NETTY and the mockless code path entirely untested. This is the codified verification that mockless behavior is correct and equivalent across modes.

Changes

  • Expanded test matrixserverConfigurations() now covers four combinations:

    • VIRTUAL_NETTY + mock server (existing)
    • NON_VIRTUAL_NETTY + mock server
    • VIRTUAL_NETTY + mockless
    • NON_VIRTUAL_NETTY + mockless
  • startServers accepts mockless flag — the mock server is always started (so mock-server tests work uniformly), but the handoff server skips the HTTP call when mockless=true, exercising doMocklessProcessing directly

  • Test display names promoted to arg {3} — description index updated to match the new 4-argument Arguments tuples

  • Javadoc updated — notes that NETTY_SCHEDULER is excluded because it requires -Djdk.virtualThreadScheduler.implClass=io.netty.loom.NettyScheduler

All three testable modes (VIRTUAL_NETTY, NON_VIRTUAL_NETTY, mock and mockless) share the same HandoffHandler/doMocklessProcessing code path — the tests confirm functional equivalence across them.


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI changed the title [WIP] Simplify benchmark runner Expand integration test coverage: NON_VIRTUAL_NETTY and mockless modes Mar 23, 2026
Copilot AI requested a review from franz1981 March 23, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants