[Repo Assist] fix: null source raises ArgumentNullException for insertAt, removeAt, updateAt#360
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
… updateAt Previously, passing null to TaskSeq.insertAt, insertManyAt, removeAt, removeManyAt, and updateAt would throw a NullReferenceException from deep within the taskSeq builder, inconsistent with every other function in the library which eagerly raises ArgumentNullException via checkNonNull. - Add checkNonNull (nameof source) source to insertAt, removeAt, removeManyAt, updateAt - Add checkNonNull "values" values to insertAt when called with Many (insertManyAt) - Add null-source tests to TaskSeq.InsertAt, RemoveAt, UpdateAt test files - 5017 tests pass (4 new null-arg tests added) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Five functions in the library (
insertAt,insertManyAt,removeAt,removeManyAt,updateAt) were missing acheckNonNullguard on thesourceparameter. Passingnullwould cause aNullReferenceExceptionburied in thetaskSeqbuilder rather than anArgumentNullExceptionat the call site — inconsistent with every other function in the module.insertManyAtalso failed to validate itsvaluesargument, which would similarly throw a confusingNullReferenceExceptionon enumeration.Root cause
The five internal helpers (
insertAt,removeAt,removeManyAt,updateAt) were added withraiseCannotBeNegativefor the index parameter but without the correspondingcheckNonNullthat is present on all other source-consuming functions.Fix
Add
checkNonNull (nameof source) source(andcheckNonNull "values" valuesfor theManycase ofinsertAt) before the lazytaskSeq { … }block in each affected function inTaskSeqInternal.fs. No logic changes.New tests
TaskSeq.InsertAt.Tests.fs: 2 new null-arg tests (Null source is invalid,Null values argument is invalid for insertManyAt)TaskSeq.RemoveAt.Tests.fs: 1 new null-arg test covering bothremoveAtandremoveManyAtTaskSeq.UpdateAt.Tests.fs: 1 new null-arg testTest Status
Build: ✅ succeeded (0 warnings, 0 errors)
Tests: ✅ 5017 passed, 2 skipped (infrastructure), 0 failed
Format: ✅
dotnet fantomas . --checkpassesBranch:
repo-assist/fix-null-checks-insertAt-removeAt-updateAt