[Repo Assist] chore: remove EOL netcoreapp3.1 test invocation from build script#476
Merged
smoothdeveloper merged 2 commits intomasterfrom Mar 16, 2026
Conversation
The test project (SqlClient.Tests.fsproj) targets net8.0 and net462 only; it has never targeted netcoreapp3.1. Running dotnet test against a framework the project does not target is a no-op at best and a spurious warning at worst. .NET Core 3.1 reached end-of-life in December 2022. Remove the dead invocation so the build script only tests against the two supported frameworks: net462 (for .NET Framework) and net8.0 (for modern .NET). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Summary
Remove a dead
DotNet.test (dnTestOptions "netcoreapp3.1")call frombuild/build.fs.Root Cause
build/build.fsruns tests against three targets:SqlClient.Tests.fsprojhas(TargetFrameworks)net8.0;net462(/TargetFrameworks)— it has never targetednetcoreapp3.1. Runningdotnet test --framework netcoreapp3.1against a project that does not include that TFM produces a no-op or a warning. More importantly, .NET Core 3.1 reached end-of-life in December 2022 and should not appear in any active build script.Fix
Remove the single line. The remaining two invocations cover both supported frameworks (
net462andnet8.0).Test Status
Build-script-only change. No library code modified. CI runs
net462andnet8.0test passes as before; thenetcoreapp3.1attempt is eliminated.