Skip to content

Fix singularization of words ending in ases#1524

Merged
dsyme merged 5 commits intofsprojects:mainfrom
bisen2:bugfix-1508
Feb 21, 2026
Merged

Fix singularization of words ending in ases#1524
dsyme merged 5 commits intofsprojects:mainfrom
bisen2:bugfix-1508

Conversation

@bisen2
Copy link
Copy Markdown
Contributor

@bisen2 bisen2 commented Mar 4, 2025

This PR would resolve #1508.

It would, however, be a breaking change. Any consumers currently using any *ases words as singular *asis would need to update their type names after updating this package.

I'm not sure if this is actually a change we would want to merge given the breaking nature, but figured I would open the PR and see what the maintainers thought.

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Mar 11, 2025

@bisen2 I'm OK with this change. Could you add a major version bump as part of the change? Thanks

@bisen2
Copy link
Copy Markdown
Contributor Author

bisen2 commented Mar 13, 2025

Sure thing. Do you want me to mark it as a beta or just go straight for the 7.0.1, @dsyme?

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Mar 21, 2025

@bisen2 Just straight to 7.0.1

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Friendly nudge from Repo Assist

Hi @bisen2! This PR has been waiting for a version bump update since March 2025 — @dsyme approved the change and asked for a bump to 7.0.1. Is there anything blocking you, or would you like help with the version bump? If you're no longer working on this, please let us know so maintainers can merge an alternative fix.

Note: an independent PR (#1600) was recently created for the same issue — if this PR gets the version bump added, it would be the preferred fix to merge as it was first.

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@6c79ed2cf36b9cfa0f5b499d00a0afc4a5d8f0c0. View source at https://github.com/githubnext/agentics/tree/6c79ed2cf36b9cfa0f5b499d00a0afc4a5d8f0c0/workflows/repo-assist.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JsonProvider] Plural word 'purchases' renamed as Purchasis in the .NET typespace

2 participants