Skip to content

Avoid compacting/merging attributes on recursive type definitions when trivia is present#3176

Draft
tboby wants to merge 9 commits intofsprojects:mainfrom
tboby:issue3174-simple
Draft

Avoid compacting/merging attributes on recursive type definitions when trivia is present#3176
tboby wants to merge 9 commits intofsprojects:mainfrom
tboby:issue3174-simple

Conversation

@tboby
Copy link
Contributor

@tboby tboby commented Aug 2, 2025

Still WIP

Fixes #3174

Please verify your pull request is respecting our Pull request ground rules.
You can find more information in our Contributors documentation section.


items |> List.fold folder [] |> List.map List.rev |> List.rev

let genCompactedAttributes (n: MultipleAttributeListNode option) =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a code comment on what this does?

@github-actions
Copy link
Contributor

🤖 This is an automated response from Repo Assist.

Hi @tboby! This PR has been in draft/WIP state since August 2025 — about 7 months without any updates. Are you still working on this fix for #3174?

If you'd like to continue, a rebase against main might be needed as the codebase has evolved considerably (including the v7.0 release and upcoming v8 alpha). If you've moved on, no worries — feel free to close it, or a maintainer can do so.

Thanks for the contribution either way!

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@828ac109efb43990f59475cbfce90ede5546586c. View source at https://github.com/githubnext/agentics/tree/828ac109efb43990f59475cbfce90ede5546586c/workflows/repo-assist.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#if in mutually recursive class definition throws

2 participants