Suggest different Discord notification action#4003
Open
watteja wants to merge 1 commit intofullstack-hy2020:sourcefrom
Open
Suggest different Discord notification action#4003watteja wants to merge 1 commit intofullstack-hy2020:sourcefrom
watteja wants to merge 1 commit intofullstack-hy2020:sourcefrom
Conversation
While the exercise description advises picking *any* action from the Marketplace that does the job, I found the inclusion of previous action to be misleading, as it is currently broken even for most basic functionality. After using embarrassing amount of time to make sure the problem was not with me, I found an alternative that can create notifications identical to the one included in the screenshots (also much more robust, given its simplicity of implementation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the exercise description advises picking any action from the Marketplace that does the job, I found the inclusion of previous action to be misleading, as it is currently broken even for most basic functionality.
After using embarrassing amount of time to make sure the problem was not with me, I found an alternative that can create notifications identical to the one included in the screenshots (also much more robust, given its simplicity of implementation). See my own notifications for proof
Ignore identical commit times for both notifications, that is not action's fault, but mine. I'm aware I shouldn't --force push, but that's outside of the scope of this PR