This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Draft
Conversation
This was referenced Jan 11, 2022
Contributor
Author
|
[ch10711] |
|
This pull request has been linked to Shortcut Story #10711: RabbitMQ queues should have a TTL. |
Contributor
Author
|
Changed to draft because we should hold off on this until we figure out if a global TTL policy can be set in AWS hosted RabbitMQ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
rabbitmq.queueTTLvalue to both forwarder and websocket service as an env varThe PRs in the forwarder and websocket service will prevent existing RabbitMQ queues from working with forwarder/websocket service. Should I add some code for backwards compatibility, or should we just go ahead with breaking these queues?