Open
Conversation
- Add startUpdateTimeJob implementation to StateCasting to update time periodically - Assign the job to _updateTimeJob in CastView so it continues updating - Call updatePlaybackTracking in VideoDetailView when time changes during casting
Zvonimir-FUTO
added
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should an issue where video watch history and view tracking were not being updated while casting. Previously, the background tasks and event listeners responsible for piping playback progression to the tracking systems were either stubbed out or disconnected during casting scenarios.
Note: While this wires up the Android architecture to support tracking during casts, the actual remote YouTube tracking still relies on the plugin's-> this was fixed after activating "Provide YouTube Activity" on the Grayjay app.source.getPlaybackTracker(url)successfully returning a payload rather thannull.