feat: improve track selection and restore audio-only for combined UMP#3229
Open
kikoso wants to merge 15 commits intofuto-org:masterfrom
Open
feat: improve track selection and restore audio-only for combined UMP#3229kikoso wants to merge 15 commits intofuto-org:masterfrom
kikoso wants to merge 15 commits intofuto-org:masterfrom
Conversation
994e511 to
9a6a78c
Compare
b4fb970 to
5d71dbc
Compare
dd18d3f to
85794ea
Compare
…multi-language UMP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores full functionality to the "Audio Only" mode when using combined UMP streams by implementing a new adapter-based bridging system that allows muxed video sources to be wrapped as audio-only equivalents. With this approach, the player can now correctly initialize playback and preserve request modifiers even when dedicated audio streams are missing due to bot-detection avoidance measures.
Together with this restoration, the update enhances track selection by integrating persistent audio and subtitle language preferences directly into the underlying ExoPlayer track selector, ensuring that internal manifest tracks are automatically prioritized based on the user's primary language and sticky subtitle settings. The user interface has also been refined in both the Video Detail and Short views to correctly display these internal manifest tracks in the quality selection menu, where a more robust deduplication algorithm ensures the list remains concise by showing only the best bitrate options per language.
Finally, the implementation resolves a bug where DASH audio manifests were being incorrectly assigned to video variables and improves overall stability through safer null-handling and reference management across the JavaScript-based source models.
Testing: