Issue : #1384 Fix blank page when resize occurs before first page is rendered#1385
Open
vince4 wants to merge 1 commit intofuturepress:masterfrom
Open
Issue : #1384 Fix blank page when resize occurs before first page is rendered#1385vince4 wants to merge 1 commit intofuturepress:masterfrom
vince4 wants to merge 1 commit intofuturepress:masterfrom
Conversation
Author
|
Issue : #1384 |
hiive
pushed a commit
to hiive/epub.js
that referenced
this pull request
Apr 6, 2026
…nitial render - Store initial display target in manager so resize handler can re-display it - Clear target after first scroll to prevent stale re-displays - Split onResized epubcfi priority: explicit CFI first, then location fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an edge case pretty hard to reproduce.
When window.resize event is triggered while
book.renderTo(is ongoing, the reader display a blank page with an empty div.To fix this bug, I suggest to save the initial target in the
manager, and send the target duringresize.And to avoid the chapter to be reset to its initial position, I suggest to reset this initial target when the view scroll.