-
Notifications
You must be signed in to change notification settings - Fork 1
Loop #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javdl
wants to merge
5
commits into
main
Choose a base branch
from
loop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Loop #96
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3623b49
feat: migrate developer site to @fashionunited/starlight-plugin-theme
javdl 1425a18
chore: sync beads — close about migration and button regression beads
javdl 4db50a3
feat: set up npm authentication for @fashionunited scope (developer-2ew)
javdl 4b489ca
feat: migrate to @fuww/starlight-plugin-theme from GitHub Packages (d…
javdl 5c433fc
fix: use git dependency for @fuww/starlight-plugin-theme instead of l…
javdl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| developer-3us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @fuww:registry=https://npm.pkg.github.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds
@fuww/starlight-plugin-themetodependencies, but the commit only updatesbun.lockband leavesbun.lockunchanged; meanwhileDockerfilerunsbun install --frozen-lockfile(lines 9 and 13), andbun install --helpdocuments that this flag “Disallow[s] changes to lockfile.” In practice, CI/container builds will fail at install time because the package manifest now requires lockfile changes that frozen mode forbids, sobun.lockneeds to be regenerated and committed with this dependency change.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude fix
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude finished @javdl's task in 1m 27s —— View job
Fixing lockfile issue
bun.lock(text lockfile) is missing@fuww/starlight-plugin-theme; Dockerfile uses--frozen-lockfilewhich requires both lockfiles to be in syncbun installto regeneratebun.locktext lockfileNote: The
bun installcommand requires approval in the current permission mode. Please approve it so I can regeneratebun.lock, or run it locally:bun install git add bun.lock bun.lockb git commit -m "fix: regenerate bun.lock text lockfile for @fuww/starlight-plugin-theme dependency" git push origin loop