Merged
Conversation
Closed
tom-karasch
added
enhancement request
|
tom-karasch
force-pushed
the
dotnet-10-take-2
branch
2 times, most recently
from
d2b607b to
159dc37
Compare
Common project properties were moved to "Directory.Build.props" files
- FluentAssertions is now AwesomeAssertions; `using` statements were updated. - MS Identity now references an `IdentityPasskeyData` class that causes as error in EF; a fix was added to the DbContext config. - The following unused NuGet packages were removed: - axios (already included as a JS lib instead) - Microsoft.Extensions.Identity.Stores - Microsoft.Graph
Build artifacts will be output in two locations: - `artifacts` for the app projects - `tests\artifacts` for the test projects The command to create a new EF migration has been simplified.
tom-karasch
force-pushed
the
dotnet-10-take-2
branch
from
9d25709 to
e800613
Compare
A vulnerable version of this package was implicitly included by EfCore.TestSupport.
dougwaldron
force-pushed
the
dotnet-10-take-2
branch
from
fccf85f to
7ae97c1
Compare
dougwaldron
added
high priority
|
Member
Author
|
@tom-karasch I recommend reviewing the SonarCloud warnings when you have time. Some are easy to fix, and some can be ignored. None IMO are blockers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supercedes #907.
Important
The new version of MS Identity in .NET 10 includes support for passkeys which requires a new DB table. Before you can deploy this update, you'll have to add a new EF migration. The good news is that the command for adding EF migrations is now much simpler.
Note that the build folder configuration has changed. Build artifacts are still in the
artifactsfolder, but the structure inside that folder is now completely different. When testing this PR or after merging, it would be a good idea to delete any existingartifactsfolder and start from scratch.Finally, I also enabled the new Microsoft Testing Platform. If you see any issues when running unit tests, please let me know.