Conversation
* Group PHP type names and factories in the same class. * Generate Go type names. * Deprecate legacy factories.
marein
force-pushed
the
9-generate-message-type-enums
branch
from
96d5700 to
15b8f2e
Compare
marein
force-pushed
the
9-generate-message-type-enums
branch
from
a31a274 to
1df32bd
Compare
marein
force-pushed
the
9-generate-message-type-enums
branch
from
1df32bd to
760d398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate message type enums for Go and PHP. PHP message factories are now placed next to their message types (the former factory classes are deprecated).
Although labeled as enums, they are implemented as constants for convenience.