Draft
Conversation
Member
|
In principle I'm fine with it, but isn't it a breaking change (based on everything we've learnt)? It might be borderline OK to include into v3 if we first make sure everything uses |
Contributor
Author
|
A breaking change might indeed be the better option, to avoid previously passing workflows suddenly failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've already stopped building IO a few times, but had to revert it every time (see e.g. 1bd4673).
With the release of
build-pkg@v3, building IO (if needed) should become the responsability of that action. This can be done by addingIOeither to theDependencies.TestPackagescomponent inPackageInfo.g, or to theextra-pkgsinput of the action.(Making this a draft PR for now since I'm not sure if we want to merge this right away)