You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the systems where CI fails, GAP's configure prints
checking for gcc option to enable C23 features... -std=gnu23
and then later GMP's configure runs into an error because of that.
checking whether to enable maintainer-specific portions of Makefiles... no
checking ABI=64
checking compiler gcc -std=gnu23 -O2 -pedantic ... no, long long reliability test 1
configure: error: could not find a working compiler, see config.log for details
make: *** [/Users/runner/gap/extern/install/gmp/lib/libgmp.la] Error 1
On the good systems:
checking for gcc option to enable C11 features... none needed
So I am guessing they changed the AC_PROG_CC macro (though on both systems I looked at the same autoconf 2.73 was used), and/or a different C/C++ compiler is installed?
So I am guessing they changed the AC_PROG_CC macro (though on both systems I looked at the same autoconf 2.73 was used), and/or a different C/C++ compiler is installed?
Maybe it's because we don't run autogen.sh on releases, but do on the development version? And doing so adds the -std=gnu23 flag? And the GMP included in GAP cannot be built against that? I'm no expert on build systems so I'm just guessing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install-pkgandbuild-pkgactions to replace theGAP_PKGS_TO_CLONEandGAP_PKGS_TO_BUILDinputs.gap-versioninputs in the example are now more representative of what we do in actual workflows.