Skip to content

Hash plain finite-field vectors and matrices#78

Merged
fingolfin merged 1 commit intomasterfrom
codex/choose-hashfunction-ffe-matrices
Mar 31, 2026
Merged

Hash plain finite-field vectors and matrices#78
fingolfin merged 1 commit intomasterfrom
codex/choose-hashfunction-ffe-matrices

Conversation

@fingolfin
Copy link
Copy Markdown
Member

Add a generic finite-field vector hash helper that computes the
minimal field of the entries via BaseDomain and feeds
NumberFFVector. Reuse it for non-compressed matrices by hashing
rows with the existing matrix-list combiner while leaving
compressed GF(2) and 8bit methods alone.

Resolves #77

Co-authored-by: Codex codex@openai.com

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.50%. Comparing base (2298578) to head (bed438e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gap/hash.gi 81.81% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   52.41%   52.50%   +0.09%     
==========================================
  Files          16       16              
  Lines        5869     5891      +22     
==========================================
+ Hits         3076     3093      +17     
- Misses       2793     2798       +5     
Files with missing lines Coverage Δ
gap/hash.gd 100.00% <100.00%> (ø)
gap/hash.gi 55.66% <81.81%> (+0.70%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add a generic finite-field vector hash helper that computes the
minimal field of the entries via BaseDomain and feeds
NumberFFVector. Reuse it for non-compressed matrices by hashing
rows with the existing matrix-list combiner while leaving
compressed GF(2) and 8bit methods alone.

Resolves #77

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin force-pushed the codex/choose-hashfunction-ffe-matrices branch from a3a9bef to bed438e Compare March 31, 2026 15:51
@fingolfin fingolfin merged commit a27a89a into master Mar 31, 2026
7 checks passed
@fingolfin fingolfin deleted the codex/choose-hashfunction-ffe-matrices branch March 31, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ChooseHashFunction methods for matrices over large fields (> 256 elements)

1 participant