always add raw image file to artifacts for tests in QEMU VM#126
Open
yeoldegrove wants to merge 1 commit intomainfrom
Open
always add raw image file to artifacts for tests in QEMU VM#126yeoldegrove wants to merge 1 commit intomainfrom
yeoldegrove wants to merge 1 commit intomainfrom
Conversation
nkraetzschmar
requested changes
Aug 27, 2025
Contributor
nkraetzschmar
left a comment
nkraetzschmar
left a comment
There was a problem hiding this comment.
There are features where we genuinely do not build raw files. We should somehow make this dependent on if the raw file is build as an intermediate target (i.e. feature provides convert scripts only), or if the feature skips building a raw file entirely (by providing custom image scripts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds the
*.rawimage file that is always created anyways to the artifacts that are uploaded to S3.We want to test those
.rawfiles in QEMU VMs. The qemu test is currently skipped with error message:https://github.com/gardenlinux/gardenlinux/actions/runs/17147445588/job/48648191622