feat: add hstore column filter support for PostgreSQL#152
Open
Ckk3 wants to merge 4 commits intogazorby:mainfrom
Open
feat: add hstore column filter support for PostgreSQL#152Ckk3 wants to merge 4 commits intogazorby:mainfrom
Ckk3 wants to merge 4 commits intogazorby:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request introduces PostgreSQL HStore support across the Strawchemy framework. Changes include a new HStore scalar type, HStore-specific comparison filters with operations (contains, containedIn, hasKey, hasKeyAll, hasKeyAny), DTO integration for field mapping, test models, fixtures, and comprehensive integration tests for HStore functionality. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@gazorby I saw that we have some problems with the lint CI, I will create a new PR to fix it 😉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 94.28% 94.32% +0.03%
==========================================
Files 69 69
Lines 5814 5854 +40
Branches 770 777 +7
==========================================
+ Hits 5482 5522 +40
Misses 190 190
Partials 142 142 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 810: The wording for the README bullet describing hasKeyAll is awkward;
update the text for the **hasKeyAll** bullet to read "have all the given keys"
instead of "have all of the given keys" so it matches nearby bullets and reads
more clearly.
In `@src/strawchemy/repository/sqlalchemy/_sync.py`:
- Line 11: Regenerate src/strawchemy/repository/sqlalchemy/_sync.py from its
source _async.py so the import order matches the original: ensure the "from
sqlalchemy import ..." line appears before the "from sqlalchemy.orm import ..."
line and that all imported symbols (e.g., ColumnElement, Row, and_, delete,
inspect, select, update and any ORM imports) and formatting exactly mirror the
_async.py source; replace the current reversed imports with the corrected
ordering from _async.py and run the generator/formatter to keep the file
consistent.
In `@src/strawchemy/schema/scalars/base.py`:
- Around line 67-68: The _parse_hstore function currently returns the original
non-dict input which violates its contract; update _parse_hstore to validate the
input and raise a clear error when value is not a dict (e.g., raise TypeError or
ValueError), and otherwise perform the existing dict[str,str] conversion
(function _parse_hstore should only accept dict inputs and reject others rather
than returning them unchanged).
In `@tests/integration/data_types/test_hstore.py`:
- Around line 95-96: The test currently asserts row-by-row equality using an
index-dependent loop (expected_ids, result.data["hstore"][i]["id"]) which makes
it order-dependent and flaky; change it to assert unordered equivalence by
collecting the returned ids (from result.data["hstore"]) and comparing as a set
(or multisets) against the expected ids derived from raw_hstore
(raw_hstore[...]["id"]) so the test validates membership regardless of row
order. Target the variables result.data["hstore"], expected_ids, and raw_hstore
when updating the assertion logic.
In `@tests/integration/fixtures.py`:
- Line 105: The current code mutates the module-global mapping scalar_overrides
in place by applying HSTORE_SCALAR_OVERRIDES, which can leak Postgres-specific
overrides; instead create a new mapping when combining them (e.g., copy
scalar_overrides or build a new dict merging scalar_overrides and
HSTORE_SCALAR_OVERRIDES) and assign that new mapping to the local variable used
for schema creation so the global scalar_overrides remains unchanged; update the
spot where scalar_overrides is combined (reference symbol: scalar_overrides and
HSTORE_SCALAR_OVERRIDES) to use a non-mutating merge.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
tests/integration/data_types/__snapshots__/test_hstore.ambris excluded by!**/__snapshots__/**
📒 Files selected for processing (13)
README.mdsrc/strawchemy/dto/inspectors/sqlalchemy.pysrc/strawchemy/repository/sqlalchemy/_sync.pysrc/strawchemy/schema/filters/__init__.pysrc/strawchemy/schema/filters/base.pysrc/strawchemy/schema/filters/inputs.pysrc/strawchemy/schema/scalars/__init__.pysrc/strawchemy/schema/scalars/base.pytests/integration/conftest.pytests/integration/data_types/test_hstore.pytests/integration/fixtures.pytests/integration/models.pytests/integration/types/postgres.py
gazorby
reviewed
Mar 16, 2026
Owner
|
I don't get what's wrong with the CI errors, they seems legit to me, and ruff can fix them for you. Have you tried? |
Contributor
Author
Yes but the errors are a little strange because CI and local env had some cache issues 🫠. I think will be nice if we merge #153 first, what you think 🙂? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for filtering on PostgreSQL
hstorecolumns. This introduces a newHStoreFilter,_HStoreComparisoninput, andHStoreGraphQL scalar, following the same patterns used by the existing JSON and Array filter implementations.Supported filter operations:
contains,containedIn,hasKey,hasKeyAll,hasKeyAny.Types of Changes
Issues Fixed or Closed by This PR
Closes #65
Checklist
Summary by CodeRabbit
Release Notes
New Features
dict[str, str]mappingDocumentation
Tests